Repository navigation
Fix: revenue summary fee columns always read 0 for ocean payouts - #303
Merged
Merged
Conversation
processTransactions tracked fees from fees_colected_satoshis, but the ocean earnpay rows spell it fees_collected_satoshis, so every fee read 0 and the revenue summary fee columns stayed empty. Read the api spelling first and keep the old one for rows stored before the fix.
arif-dewi
approved these changes
Oct 12, 2026
tekwani
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
`processTransactions` tracks fees from `fees_colected_satoshis`, but the ocean earnpay rows carry the field as `fees_collected_satoshis` (the API spelling). The lookup never matches, so `feesBTC`/`feesUSD` in the revenue summary are 0 for every ocean payout.
Found while QA-ing the phase reporting work on a local stack: fee-bearing fixture rows came back with `feesBTC: 0`.
Fix
Read the API spelling first and keep the old key as a fallback for anything stored under it.
Testing