Skip to content

feat: Secure connections (TLS/Basic auth) + Fast Frame reliability improvements - #188

Closed
SaiDeepikaKuchibhotla wants to merge 23 commits into
tektronix:mainfrom
SaiDeepikaKuchibhotla:ff_feature-legacy-backup
Closed

SaiDeepikaKuchibhotla wants to merge 23 commits into
tektronix:mainfrom
SaiDeepikaKuchibhotla:ff_feature-legacy-backup

Conversation

@SaiDeepikaKuchibhotla

Copy link
Copy Markdown
Contributor

Proposed changes

Adds secure connection support (TLS / Basic authentication) to TekHSIConnect and brings in the FastFrame reliability/diagnostic work, along with supporting examples, tests, and documentation.

Addresses #< fill in issue number here >

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Functionality update (non-breaking change which updates or changes existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)
  • Documentation update (an update to enhance the user experience when reading through the docs)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have created (or updated) an Issue to track the status of this update/change and updated the link in this PR description (see above in the Proposed changes section) using the wording Addresses #<issue_number>
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Comment thread src/tekhsi/security.py Fixed
Comment thread src/tekhsi/security.py Fixed
Comment thread src/tekhsi/security.py Fixed
Comment thread src/tekhsi/security.py Fixed
Comment thread examples/auth_helpers.py Fixed
Comment thread tests/manual/probe_endpoint_security.py Fixed
Comment thread scripts/probe_endpoint_security.py Fixed
Comment thread scripts/probe_endpoint_security.py Fixed
Comment thread tests/manual/tekhsi_conn.py Fixed
Comment thread src/tekhsi/_tek_highspeed_server_pb2_grpc.py Fixed
Comment thread scripts/check_tekhsi_endpoint.py Fixed
Comment thread scripts/check_tekhsi_endpoint.py Fixed
Comment thread src/tekhsi/security.py Fixed
Comment thread .github/workflows/update-python-dependencies.yml Outdated
Comment thread docs/.linkchecker.ini Outdated
Comment thread docs/.linkchecker.ini Outdated
Comment thread normalizedvector.proto Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in the root?

Comment thread docs/DEMO_README.md

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filename is not great

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Breaking API Changes

src/tekhsi/_tek_highspeed_server_pb2.py:185: WaveformHeader.__slots__:
Attribute value was changed:
  Old: ['bitmask', 'chunksize', 'dataid', 'hasdata', 'horizontalUnits', 'horizontalfractionalzeroindex', 'horizontalspacing', 'horizontalzeroindex', 'iq_centerFrequency', 'iq_fftLength', 'iq_rbw', 'iq_span', 'iq_windowType', 'noofsamples', 'pairtype', 'sourcename', 'sourcewidth', 'transid', 'verticaloffset', 'verticalspacing', 'verticalunits', 'wfmtype']
  New: ('sourcename', 'sourcewidth', 'dataid', 'transid', 'horizontalUnits', 'horizontalspacing', 'horizontalzeroindex', 'horizontalfractionalzeroindex', 'noofsamples', 'chunksize', 'wfmtype', 'bitmask', 'pairtype', 'verticalunits', 'verticalspacing', 'verticaloffset', 'iq_centerFrequency', 'iq_fftLength', 'iq_rbw', 'iq_span', 'iq_windowType', 'hasdata', 'num_frames', 'frame_info', 'current_frame_index', 'probe_details', 'channel_sparam')

Link to workflow run

@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Test Results (ubuntu)

path passed skipped subtotal
tests/manual/test_scope_waveform.py 3 3
tests/test_auth_basic.py 14 14
tests/test_client.py 86 86
tests/test_credential_store.py 20 20
tests/test_load_timing.py 9 9
tests/test_logging.py 3 3
tests/test_security.py 38 38
tests/test_security_wiring.py 4 4
tests/test_tek_hsi_connect_security.py 19 19
tests/test_wfm_digital.py 10 10
TOTAL 203 3 206
tests/manual/test_scope_waveform.py
('/home/runner/work/TekHSI/TekHSI/tests/manual/test_scope_waveform.py', 41, 'Skipped: Manual scope test — set TEKHSI_RUN_MANUAL_SCOPE=1 and TEKHSI_SCOPE_URL. Or run: python tests/manual/manual_scope_waveform.py')('/home/runner/work/TekHSI/TekHSI/tests/manual/test_scope_waveform.py', 41, 'Skipped: Manual scope test — set TEKHSI_RUN_MANUAL_SCOPE=1 and TEKHSI_SCOPE_URL. Or run: python tests/manual/manual_scope_waveform.py')('/home/runner/work/TekHSI/TekHSI/tests/manual/test_scope_waveform.py', 41, 'Skipped: Manual scope test — set TEKHSI_RUN_MANUAL_SCOPE=1 and TEKHSI_SCOPE_URL. Or run: python tests/manual/manual_scope_waveform.py')

Link to workflow run

@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Test Results (macos)

path passed skipped subtotal
tests/manual/test_scope_waveform.py 3 3
tests/test_auth_basic.py 14 14
tests/test_client.py 86 86
tests/test_credential_store.py 20 20
tests/test_load_timing.py 9 9
tests/test_logging.py 3 3
tests/test_security.py 38 38
tests/test_security_wiring.py 4 4
tests/test_tek_hsi_connect_security.py 19 19
tests/test_wfm_digital.py 10 10
TOTAL 203 3 206
tests/manual/test_scope_waveform.py
('/Users/runner/work/TekHSI/TekHSI/tests/manual/test_scope_waveform.py', 41, 'Skipped: Manual scope test — set TEKHSI_RUN_MANUAL_SCOPE=1 and TEKHSI_SCOPE_URL. Or run: python tests/manual/manual_scope_waveform.py')('/Users/runner/work/TekHSI/TekHSI/tests/manual/test_scope_waveform.py', 41, 'Skipped: Manual scope test — set TEKHSI_RUN_MANUAL_SCOPE=1 and TEKHSI_SCOPE_URL. Or run: python tests/manual/manual_scope_waveform.py')('/Users/runner/work/TekHSI/TekHSI/tests/manual/test_scope_waveform.py', 41, 'Skipped: Manual scope test — set TEKHSI_RUN_MANUAL_SCOPE=1 and TEKHSI_SCOPE_URL. Or run: python tests/manual/manual_scope_waveform.py')

Link to workflow run

@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Test Results (windows)

path passed skipped xpassed subtotal
tests\manual\test_scope_waveform.py 3 3
tests\test_auth_basic.py 14 14
tests\test_client.py 81 5 86
tests\test_credential_store.py 20 20
tests\test_load_timing.py 9 9
tests\test_logging.py 3 3
tests\test_security.py 38 38
tests\test_security_wiring.py 4 4
tests\test_tek_hsi_connect_security.py 19 19
tests\test_wfm_digital.py 10 10
TOTAL 198 3 5 206
tests\manual\test_scope_waveform.py
('D:\\a\\TekHSI\\TekHSI\\tests\\manual\\test_scope_waveform.py', 41, 'Skipped: Manual scope test � set TEKHSI_RUN_MANUAL_SCOPE=1 and TEKHSI_SCOPE_URL. Or run: python tests/manual/manual_scope_waveform.py')('D:\\a\\TekHSI\\TekHSI\\tests\\manual\\test_scope_waveform.py', 41, 'Skipped: Manual scope test � set TEKHSI_RUN_MANUAL_SCOPE=1 and TEKHSI_SCOPE_URL. Or run: python tests/manual/manual_scope_waveform.py')('D:\\a\\TekHSI\\TekHSI\\tests\\manual\\test_scope_waveform.py', 41, 'Skipped: Manual scope test � set TEKHSI_RUN_MANUAL_SCOPE=1 and TEKHSI_SCOPE_URL. Or run: python tests/manual/manual_scope_waveform.py')

Link to workflow run

@SaiDeepikaKuchibhotla
SaiDeepikaKuchibhotla deleted the ff_feature-legacy-backup branch October 5, 2026 15:39

This branch was successfully deployed

1 active deployment
package-build — 347a222c Deployed Oct 3, 2026 by SaiDeepikaKuchibhotla via package-build / Build package #459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants