Repository navigation
[cherry-pick: release-v0.37.x] fix: use latest Tekton releases and fix ConfigMap timing issue - #3335
Open
divyansh42 wants to merge 1 commit into
Conversation
Update E2E test setup to use latest stable releases and fix ConfigMap timing issue: **Pipelines:** - Remove v1.12.0 pin and use latest release - Remove TODO comment about switching back to latest **Triggers:** - Skip nightly builds and use latest release directly - Fix timing: wait for pods AFTER applying interceptors (not before) **Root Cause:** Triggers v0.37.1 added config-triggers-core-interceptors ConfigMap for GitHub Enterprise allowlist feature. The controller fatally crashes on startup if this ConfigMap doesn't exist, even though the feature defaults to disabled. Old broken order caused controller to crash: 1. Apply release.yaml (creates controller Deployment) 2. **Wait for pods** (controller starts, needs ConfigMap, crashes) 3. Apply interceptors.yaml (ConfigMap created too late) **Fix (matching tektoncd/triggers pattern):** 1. Apply release.yaml (creates CRDs and Deployment) 2. Wait for ClusterInterceptor CRD to be Established (provides delay for image pull) 3. Apply interceptors.yaml (creates ConfigMap before controller starts) 4. Wait for pods (controller finds ConfigMap, starts successfully) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> (cherry picked from commit bb65fb6)
tekton-robot
added
the
release-note-none
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/M
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #3298
Changes
Update E2E test setup to use latest stable releases and fix the Triggers ConfigMap timing issue (test infrastructure only,
test/e2e-common.sh).Pipelines:
https://infra.tekton.dev/tekton-releases/pipeline/latest/release.yaml(replaces thestorage.googleapis.comURL on this branch; there is nov1.12.0pin here)Triggers:
infra.tekton.devinterceptors.yaml(not before), so theconfig-triggers-core-interceptorsConfigMap exists when the controller startsSubmitter Checklist
make check— N/A, shell script only (bash -npasses)make generated— N/A, no code changesSee the contribution guide
for more details.
Release Notes