Repository navigation
feat: support structured JSON/YAML output for bulk delete operations - #3334
Open
arvindk-softwaredev wants to merge 1 commit into
Open
arvindk-softwaredev wants to merge 1 commit into
arvindk-softwaredev wants to merge 1 commit into
Conversation
tekton-robot
added
the
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/XXL
arvindk-softwaredev
marked this pull request as draft
October 8, 2026 10:27
tekton-robot
added
the
do-not-merge/work-in-progress
arvindk-softwaredev
force-pushed
the
feat/structuredOutput-delete-command
branch
from
October 8, 2026 10:44
ce3e614 to
a1a845c
Compare
Contributor
Author
arvindk-softwaredev
marked this pull request as ready for review
October 8, 2026 10:50
tekton-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/retest |
tekton-robot
added
the
needs-rebase
Extend -o json/yaml support to bulk delete scenarios across task, pipeline, pipelinerun, eventlistener, triggerbinding, triggertemplate, and clustertriggerbinding delete commands. Signed-off-by: Arvind Krishnamurthy <arvkrish@redhat.com> Assisted-by: Grok 4.7 (via Cursor)
arvindk-softwaredev
force-pushed
the
feat/structuredOutput-delete-command
branch
from
October 9, 2026 04:44
a1a845c to
1f23a1e
Compare
tekton-robot
added
size/XL
Contributor
Author
|
/retest |
2 similar comments
Member
|
/retest |
Member
|
/retest |
There was a problem hiding this comment.
🟡 Changes recommended
PipelineRun retention can bypass structured output, and the release note incorrectly claims CustomRun bulk support.
2 open findings
What changed in this PR
Extends machine-readable JSON/YAML output to bulk delete operations across Tekton CLI resources.
Changes:
- Enables structured output for bulk deletion and skips confirmation prompts.
- Adds coverage for JSON/YAML output, selectors, retention, and partial failures.
- Regenerates command and manpage documentation.
| File | Description |
|---|---|
pkg/cmd/triggertemplate/delete.go |
Enables structured bulk-delete output. |
pkg/cmd/triggertemplate/delete_test.go |
Tests JSON/YAML bulk deletion. |
pkg/cmd/triggerbinding/delete.go |
Enables structured bulk-delete output. |
pkg/cmd/triggerbinding/delete_test.go |
Tests JSON/YAML bulk deletion. |
pkg/cmd/task/delete.go |
Adds structured --all results. |
pkg/cmd/task/delete_test.go |
Tests Task bulk output and validation. |
pkg/cmd/pipelinerun/delete.go |
Adds structured bulk and filtered results. |
pkg/cmd/pipelinerun/delete_test.go |
Tests bulk, retention, selectors, and failures. |
pkg/cmd/pipeline/delete.go |
Adds structured --all results. |
pkg/cmd/pipeline/delete_test.go |
Tests output, validation, and partial failures. |
pkg/cmd/eventlistener/delete.go |
Enables structured bulk-delete output. |
pkg/cmd/eventlistener/delete_test.go |
Tests JSON/YAML bulk deletion. |
pkg/cmd/clustertriggerbinding/delete.go |
Enables cluster-wide structured deletion. |
pkg/cmd/clustertriggerbinding/delete_test.go |
Tests JSON/YAML bulk deletion. |
docs/man/man1/tkn-triggertemplate-delete.1 |
Documents bulk structured output. |
docs/man/man1/tkn-triggerbinding-delete.1 |
Documents bulk structured output. |
docs/man/man1/tkn-task-delete.1 |
Documents bulk and related output. |
docs/man/man1/tkn-pipelinerun-delete.1 |
Documents bulk and filtered output. |
docs/man/man1/tkn-pipeline-delete.1 |
Documents bulk and related output. |
docs/man/man1/tkn-eventlistener-delete.1 |
Documents bulk structured output. |
docs/man/man1/tkn-clustertriggerbinding-delete.1 |
Documents cluster-wide output. |
docs/cmd/tkn_triggertemplate_delete.md |
Updates command examples. |
docs/cmd/tkn_triggerbinding_delete.md |
Updates command examples. |
docs/cmd/tkn_task_delete.md |
Updates command examples. |
docs/cmd/tkn_pipelinerun_delete.md |
Updates command examples. |
docs/cmd/tkn_pipeline_delete.md |
Updates command examples. |
docs/cmd/tkn_eventlistener_delete.md |
Updates command examples. |
docs/cmd/tkn_clustertriggerbinding_delete.md |
Updates command examples. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| return err | ||
| } | ||
| return d.Errors() | ||
| if formatted.IsStructured(output) { |
| } | ||
| d.PrintSuccesses(s) | ||
| } else if opts.DeleteAllNs { | ||
| if formatted.IsStructured(output) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2850
Changes
Extend -o json/yaml support to bulk delete
--allscenarios across task, pipeline,pipelinerun, eventlistener, triggerbinding, triggertemplate, and
clustertriggerbinding delete commands.
TaskRun is excluded (covered by #3086).
The bulk delete result is returned as machine-readable output.
-o json/-o yaml skips the confirmation prompt (same as -f) so the
command can run non-interactively.
Example:
Above output structure is the same for all resources.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes