[chmouel]

Changes

Adds support for the XDG Base Directory Specification when resolving the default bundle cache directory.

When --cache-dir is not set, tkn picks the default in this order:

1. ~/.tekton/bundles, if ~/.tekton already exists (kept for backward compatibility)
2. $XDG_CACHE_HOME/tkn/bundles, if XDG_CACHE_HOME is set to an absolute path
3. ~/.cache/tkn/bundles otherwise

It also replaces the mitchellh/go-homedir dependency with a small internal ~ expansion helper (pkg/bundle/cache_dir.go), and --cache-dir now rejects an empty value instead of silently caching in the current directory.

See this article why repescting XDG is important (event on OSX/WSL): https://maex.me/2019/12/the-power-of-the-xdg-base-directory-specification/

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Run the code checkers with make check
• Regenerate the manpages, docs and go formatting with make generated
• Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

`tkn bundle list` now follows the XDG Base Directory Specification for its default cache location: `$XDG_CACHE_HOME/tkn/bundles`, or `~/.cache/tkn/bundles` if unset. It falls back to the legacy `~/.tekton/bundles` only when that directory already exists.

NOTE: I have used AI for implementing this feature but reviewed it myself, gpt-6-luna

[Copilot]

Copilot review overview

🟡 Changes recommended

Relative XDG paths incorrectly fail instead of being ignored, and the displayed static default contradicts runtime selection.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 · 1

Open (2)

• Ignore relative XDG_CACHE_HOME and use the fallback directory · New
• Avoid hard-coded dynamic cache path in flag defaults and docs · New

What changed in this PR

Adds XDG-aware default bundle-cache resolution while preserving legacy cache compatibility.

Changes:

• Adds cache-directory resolution and ~ expansion.
• Rejects empty --cache-dir values and expands test coverage.
• Updates CLI help and generated documentation.

File	Description
pkg/​bundle/​cache_dir.go	Implements cache-path selection.
pkg/​bundle/​cache_dir_test.go	Tests cache-path precedence.
pkg/​bundle/​flags.go	Adds validated cache flag handling.
pkg/​bundle/​remote.go	Applies resolved cache paths.
pkg/​bundle/​remote_test.go	Tests caching integration.
pkg/​cmd/​bundle/​list.go	Updates cache help text.
pkg/​cmd/​bundle/​list_test.go	Tests explicit and empty flags.
docs/​cmd/​tkn_bundle_list.md	Updates generated command documentation.
docs/​man/​man1/​tkn-bundle-list.1	Updates generated manpage.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟢 Approval recommended

The cache-selection behavior, validation, tests, and generated documentation are consistent and complete.

Review effort: Balanced
Findings: None

Resolved since last review (2)

• Ignore relative XDG_CACHE_HOME and use the fallback directory
• Avoid hard-coded dynamic cache path in flag defaults and docs

[divyansh42]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment