Repository navigation
chore(github-*): bump apiVersion from v1beta1 to v1 - #1393
Merged
Merged
Conversation
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Diff between version 0.1 and 0.2diff --git a/task/create-github-release/0.1/README.md b/task/create-github-release/0.2/README.md
index 02747ed..59044b6 100644
--- a/task/create-github-release/0.1/README.md
+++ b/task/create-github-release/0.2/README.md
@@ -13,7 +13,7 @@ Task can also be used to upload multiple `assets` including `binaries` of the re
## Install the Task
```
-kubectl apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/create-github-release/0.1/create-github-release.yaml
+kubectl apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/create-github-release/0.2/create-github-release.yaml
```
## Parameters
@@ -57,7 +57,7 @@ Release can be created at a particular branch, tag or commit sha, to achieve tha
required branch, tag or commit sha can be added in the param `commitish`.
Github repository on which release has to be performed must be available in the workspace named `source`. This can be done using
-[git-clone](https://github.com/tektoncd/catalog/blob/main/task/git-clone/0.1/git-clone.yaml) task as shown [here](../0.1/samples/run.yaml).
+[git-clone](https://github.com/tektoncd/catalog/blob/main/task/git-clone/0.1/git-clone.yaml) task as shown [here](../0.2/samples/run.yaml).
To make a release put all the required params, add required secrets and release will be done.
@@ -73,7 +73,7 @@ stringData:
GITHUB_TOKEN: $(personal_access_token)
```
-[This](../0.1/samples) example uses ConfigMap for mounting asset file to the workspace, ConfigMap can be created as follows:
+[This](../0.2/samples) example uses ConfigMap for mounting asset file to the workspace, ConfigMap can be created as follows:
```
kubectl create configmap upload-asset --from-file=file1.txt --from-file=file2.txt
diff --git a/task/create-github-release/0.1/create-github-release.yaml b/task/create-github-release/0.2/create-github-release.yaml
index 5347d16..3e3b600 100644
--- a/task/create-github-release/0.1/create-github-release.yaml
+++ b/task/create-github-release/0.2/create-github-release.yaml
@@ -1,11 +1,11 @@
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
kind: Task
metadata:
name: create-github-release
labels:
- app.kubernetes.io/version: "0.1"
+ app.kubernetes.io/version: "0.2"
annotations:
- tekton.dev/pipelines.minVersion: "0.12.1"
+ tekton.dev/pipelines.minVersion: "0.50.0"
tekton.dev/categories: Git
tekton.dev/tags: github
tekton.dev/displayName: "create github release"
diff --git a/task/create-github-release/0.1/samples/run.yaml b/task/create-github-release/0.2/samples/run.yaml
index ae27760..1a08c20 100644
--- a/task/create-github-release/0.1/samples/run.yaml
+++ b/task/create-github-release/0.2/samples/run.yaml
@@ -1,4 +1,4 @@
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
kind: Pipeline
metadata:
name: create-github-release-pipeline
@@ -45,7 +45,7 @@ spec:
- name: release-notes
workspace: release-notes
---
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
kind: PipelineRun
metadata:
name: create-github-release-pipeline-run |
Contributor
Author
|
/assign @vdemeester |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Mechanical API version bump for the github-* task family, as part of the
v1beta1 → v1 migration tracked in #1381.
Tasks updated
Each task was created using
copy-then-modifyper CONTRIBUTING.md: one commitcopies the previous version directory, a second commit applies the version bump.
None of these tasks use PipelineResources or other v1beta1-only constructs.
Image pinning
Digests were resolved with
skopeo inspectagainst the current tag:registry.access.redhat.com/ubi8/ubi-minimal:8.2sha256:5cfbaf45ca96806917830c183e9f37df2e913b187aadb32e89fd83fa455ebaa6registry.access.redhat.com/ubi8/ubi:8.2sha256:d748c21a55796827da82c61f162b505c59451cba24f1874e5185f21275b6bddcregistry.access.redhat.com/ubi8/python-38:1-34.1599745032sha256:9a6830a753a77b0a2dc140d05bdf56f35c41867fa06c9b30366216e65bc600b3Conflict note
#1386 is still open and also creates
github-add-comment/0.8(without an APIbump). This PR starts from current
0.7. If #1386 merges first, this will needa version rebase to
0.9.Validation
yamllintpasses for all modified filestekton.dev/v1beta1references in any of the new version directoriesNote on pre-existing conditions
Several of these tasks interpolate
$(params.*)directly inscript:blocks.github-set-statusstill takes its image via a param (defaultpython:3.10.1-alpine3.15). Those are inherited from the previous versions andnot introduced by this PR. Script injection hardening will be addressed in
follow-up PRs as part of #1381.
Ref: #1381
/kind cleanup
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
contains
/kind <type>. Valid types are bug, cleanup, design, documentation,feature, flake, misc, question, tep
File path follows
<kind>/<name>/<version>/name.yamlHas
README.mdat<kind>/<name>/<version>/README.mdHas mandatory
metadata.labels-app.kubernetes.io/versionthe same as the<version>of the resourceHas mandatory
metadata.annotationstekton.dev/pipelines.minVersionmandatory
spec.descriptionfollows the conventionSee the contribution guide for more details.