Repository navigation
Conversation
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Diff between version 0.1 and 0.2diff --git a/task/istio-canary-release/0.1/README.md b/task/istio-canary-release/0.2/README.md
index 63e2e9a..61d8b73 100644
--- a/task/istio-canary-release/0.1/README.md
+++ b/task/istio-canary-release/0.2/README.md
@@ -19,13 +19,13 @@ kubectl apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/ku
2. For Istio Services
```bash
-kubectl apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/istio-canary-release/0.1/istio-canary-release.yaml
+kubectl apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/istio-canary-release/0.2/istio-canary-release.yaml
```
## Installing the ClusterRoleBinding
```bash
-kubectl apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/istio-canary-release/0.1/support/clusterrolebinding.yaml
+kubectl apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/istio-canary-release/0.2/support/clusterrolebinding.yaml
```
## Workspaces
diff --git a/task/istio-canary-release/0.1/istio-canary-release.yaml b/task/istio-canary-release/0.2/istio-canary-release.yaml
index 1bd23aa..588e38d 100644
--- a/task/istio-canary-release/0.1/istio-canary-release.yaml
+++ b/task/istio-canary-release/0.2/istio-canary-release.yaml
@@ -1,11 +1,11 @@
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
kind: Task
metadata:
name: istio-canary-release
labels:
- app.kubernetes.io/version: "0.1"
+ app.kubernetes.io/version: "0.2"
annotations:
- tekton.dev/pipelines.minVersion: "0.12.1"
+ tekton.dev/pipelines.minVersion: "0.50.0"
tekton.dev/categories: Deployment
tekton.dev/tags: canary deployment, istio
tekton.dev/displayName: "istio canary release"
@@ -40,7 +40,7 @@ spec:
default: ""
steps:
- name: canary-deploy
- image: quay.io/openshift/origin-cli:4.6
+ image: quay.io/openshift/origin-cli:4.6@sha256:6722d5041b472ac61a294647f7fa02fb432a948835bb780cc73cd221a9291a2c
workingDir: $(workspaces.istio-manifest-dir.path)
script: |
#!/usr/bin/env bash
diff --git a/task/istio-canary-release/0.1/samples/run.yaml b/task/istio-canary-release/0.2/samples/run.yaml
index 1a8e398..6b847b4 100644
--- a/task/istio-canary-release/0.1/samples/run.yaml
+++ b/task/istio-canary-release/0.2/samples/run.yaml
@@ -1,4 +1,4 @@
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
kind: Pipeline
metadata:
name: canary-deployment
@@ -31,7 +31,7 @@ spec:
- name: istio-manifest-dir
workspace: istio-manifest-dir
---
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
kind: PipelineRun
metadata:
name: canary-deployment-run
diff --git a/task/istio-canary-release/0.1/samples/taskrun.yaml b/task/istio-canary-release/0.2/samples/taskrun.yaml
index 3e9c451..f39f573 100644
--- a/task/istio-canary-release/0.1/samples/taskrun.yaml
+++ b/task/istio-canary-release/0.2/samples/taskrun.yaml
@@ -1,4 +1,4 @@
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
kind: TaskRun
metadata: istio-run
spec: |
|
/assign @vdemeester |
PipelineRun v1 removed spec.serviceAccountName in favor of spec.taskRunTemplate.serviceAccountName. The old field causes strict decoding errors on Tekton >= 0.50.0. Affected tests: - helm-upgrade-from-repo/0.4/tests/run.yaml - helm-upgrade-from-source/0.5/tests/run.yaml Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
|
The e2e failures were caused by Two test files affected:
The Fixed in 303c653. The pattern matches what |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Mechanical API version bump for the argocd + deployment/CD task family, as part of the
v1beta1 → v1 migration tracked in #1381.
Tasks updated
namespace: argocdorigin-cli:4.6to digest, samples bumpedEach task was created using
copy-then-modifyper CONTRIBUTING.md: one commitcopies the previous version directory, a second commit applies the version bump.
None of these tasks use PipelineResources or other v1beta1-only constructs.
argocd-task-connect-repohadmetadata.namespace: argocdhardcoded. Catalogtasks should not pin a namespace, so that field was dropped in 0.2.
istio-canary-releasereferencedquay.io/openshift/origin-cli:4.6without adigest. 0.2 pins it to
@sha256:6722d5041b472ac61a294647f7fa02fb432a948835bb780cc73cd221a9291a2c.Note: #1318 is still open and also creates
helm-upgrade-from-repo/0.4(withoutan API bump). This PR starts from current
0.3. If #1318 merges first, thiswill need a version rebase to
0.5.Validation
yamllintpasses for all modified filestekton.dev/v1beta1references in any of the new version directoriesNote on pre-existing conditions
Several of these tasks interpolate
$(params.*)directly inscript:blocks,and some keep mutable image defaults via params (e.g.
kn-apply:latest).Those are inherited from the previous versions and not introduced by this PR.
Script injection hardening will be addressed in follow-up PRs as part of #1381.
Ref: #1381
/kind cleanup
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
contains
/kind <type>. Valid types are bug, cleanup, design, documentation,feature, flake, misc, question, tep
File path follows
<kind>/<name>/<version>/name.yamlHas
README.mdat<kind>/<name>/<version>/README.mdHas mandatory
metadata.labels-app.kubernetes.io/versionthe same as the<version>of the resourceHas mandatory
metadata.annotationstekton.dev/pipelines.minVersionmandatory
spec.descriptionfollows the conventionSee the contribution guide for more details.