Repository navigation
ミニマルとポップを追加し、同梱デザインテーマを4種類にする - #66
Merged
Merged
Conversation
Hands an outside agent everything needed to add a "minimal" (Less but better) and a "pop" theme without reading the whole repository: why those two directions do not collide with the existing dark HUD and retro LCD, the four files a theme touches, the 67-variable contract including the --fx-* formats that app.js parses at runtime, and the checks to run before a PR. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012wNSUjsfpkg256wh6Utxom
The tester's own backlog moves at the same time as this theme work, and two items overlap on disk: the horizontal-scroll indicator edits tools/visual-check.js, and roadmap.md was already written to expect more themes. Name the files this task may touch, cap the visual-check edit at the THEMES line, and drop the roadmap update from the request. Also require a single agent for the whole job: the file fence and the --fx-* format contract travel badly across delegation, and judging two themes from screenshots needs one pair of eyes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012wNSUjsfpkg256wh6Utxom
中性グレーの面、細い境界、小さな角丸とシステムフォントで機能を際立たせる。 押下は白黒反転、操作はオレンジ、正常・完了はグリーンで示す。 CSSのグローと装飾を減らし、軌跡は固定RGBの単色にする。 変更は minimal.css の追加と、themes.js / index.html / visual-check.js の登録のみ。 visual-check.js は const THEMES の1行だけを変更。style.css / stage.css は未変更。 SPDX、--fx-* の書式、--u の維持、外部依存なしを確認。 git merge origin/main の結果を含む1コミットにまとめる。 検証: - node --test tools/boards.test.js tools/scroll-input.test.js tools/vial-layout.test.js: 24件 pass - node tools/visual-check.js: Chromium 150.0.7871.100 / 3サイズ x 3テーマ x 15状態 = 135枚、全件 pass NODE_PATH と CHROMIUM_PATH、LD_LIBRARY_PATH は検証環境の既存Playwright・検証用Chromiumを指定。 - 1024x768 / 2560x1440: 刻印、押下・Fn破線、計測値、アトラクト、ガイドを目視。 スタッフメニューと合成Vialのツアー選択スクリムも別途撮影・目視。 - テーマ選択と再読み込み後の保持、--fx-* の実値を追加確認。 制約による残事項: - Canvasのグロー強度・線幅・ハローは ui/app.js に固定され、変数だけでは除去・細線化できないため維持。 - ツアー実行中のスクリム非表示は stage.css の既存仕様を維持。 - ドキュメント更新は今回の4ファイル制限に従い対象外。visual-checkの実測は135枚。 - OLSK60 / 展示PCのWebView2: 要確認。合成Vialフィクスチャは実機検証ではない。
The theme collapsed left, middle and right click onto one orange, so the ripple, the counter and the live feed all looked the same — the tester exists to show what the pointing device just did, and that reading was lost. Keep the restraint by spending no new hue: accent for left, the theme's mid grey for middle, ink for right, the same ladder lcd.css uses. The counter and the feed follow the same mapping so both surfaces agree. Measured on the theme background: 5.23:1, 5.38:1 and 15.15:1, all above 4.5:1. Left and middle separate by hue rather than lightness (1.03:1 between them), and both carry their 左/中/右 label, so the colour is a second cue rather than the only one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012wNSUjsfpkg256wh6Utxom
The minimal theme assigned one orange to all three mouse buttons and the review caught it late, because three identical values look deliberate in a CSS file. State the requirement for both surfaces that carry it, and say to read the resolved values back from the browser rather than eyeballing the stylesheet. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012wNSUjsfpkg256wh6Utxom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
既存の暗色・紙色に、静かな明色の「ミニマル」と、明るい色面の「ポップ」を追加して同梱テーマを4種類にします。
この作業ではミニマルのコミットとクリック3色の追加修正を引き継ぎ、その上に
ed0f442「ポップテーマの追加」、9675b37「ドキュメント更新」の2コミットを積みました。単一エージェントで実施し、PR前にgit fetch originとgit merge origin/mainを実行しています。変更内容
ui/themes/pop.css、ui/themes.jsの登録1行、ui/index.htmlのlink1行、tools/visual-check.jsのconst THEMES1行のみ。README.md、docs/guide/features.md、docs/development.mdのテーマ説明・撮影枚数を更新。--fx-*の書式、--uの維持を確認。外部依存・画像・Webフォント・背景アニメーションは追加していません。ui/style.css、ui/stage.css、入力処理、撮影状態・サイズは変更していません。検証
node --test tools/boards.test.js tools/scroll-input.test.js tools/vial-layout.test.js：ポップ・文書・mainマージの各コミットを個別に展開し、各24件pass。node tools/visual-check.js <出力先>：3サイズ × 4テーマ × 15状態 = 180枚、全件pass。Chromium 150.0.7871.100、GPU無効、約203.8秒。既存Playwrightと検証用ChromiumをNODE_PATH/CHROMIUM_PATH/LD_LIBRARY_PATHで指定。導入物はリポジトリに含めていません。getComputedStyleとCanvasパレットで、全4テーマの左/中/右が波紋・カウンタ・ライブフィードの各々で3色に分かれることを確認。最新のミニマルの3色修正も取り込み後に確認済み。git diff --check：pass。ポップ作業の変更は依頼書§8の7ファイルのみ。描画の制約・要確認
ui/app.jsに固定され、変数化されていません。今回の範囲では配色を反映し、これらの描画仕様は維持しています。stage.cssの仕様を維持。ツアー選択メニューのスクリムは確認済み。