Repository navigation
Conversation
|
Hm, this doesn't actually seem like it resolves that issue to me? If the problem is that you have a spec that has diagrams that are unreadable in dark mode, and you don't want to fix that, giving your users the ability to manually re-enable light mode after the page has loaded isn't much of a solution. |
|
@bakkot multiple things can be true: we should figure out a way for graphics to render nicely in dark mode, and we shouldn't assume what users want to the degree that we don't allow them to choose. |
|
@bakkot I completely agree. As stated in the issue:
|
| // a change to the system's scheme is a new preference, so go back to following it | ||
| systemPrefersDark.addEventListener('change', () => { | ||
| if (colorSchemeInverted) { | ||
| toggleColorScheme(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
I switch between light and dark mode system-wide in the night (but I rarely look at ecma262 when that happens, so I almost never look at the dark mode version 😅).
It would be better if the states were light/dark/system so that one can either set a preference or choose to follow what the system does, rather than ecma262 forgetting my preference (if I'll set any) every time the change happens.
There was a problem hiding this comment.
Or, if you want a two-state toggle, following what @LeaVerou suggests on her blog post: https://lea.verou.me/blog/2026/dark-mode-toggles/
Another common mistake is being overzealous about removing the stored value when the system preference changes, even if the user has explicitly set an override.
This evaluation must only happen at user interaction.
(fwiw Lea, I find your analogy with tap faucets to be quite... leaking. The best faucets are the ones with two separate knobs, one for pressure and one for temperature. The worse ones are those with a single one-axis knob that somehow controls both parameters, and that I've only found in American and Japanese hotels).
|
I would prefer not to have a dedicated button taking up valuable screen real estate for this. We already have the multipage preference configured via the keyboard shortcuts help dialogue. Can this be placed next to it? |
resolves #647