Repository navigation
Re-export every logo and give light variants a white background - #33
Merged
Merged
Conversation
Exports all 338 frames through import/ and pnpm run import-payments, so SVGO runs over the whole set again. Two things change for consumers. Light logos now carry a solid white background. The export frames hold an instance of the Payment component, and contentsOnly only drops the frame's own fill, not the instance's, so the component background lands in the SVG. Before, 162 of 169 light files were transparent and 7 were not; now all 169 are white, which at least makes them consistent. SVGO cuts the payload from 1.78 MB to 814 KB and finally prefixes the gradient ids: 23 files used to ship generic names like paint0_linear_115 that could collide when light and dark render in one document, as they do on the preview page. Rendering every file before and after on a white background and comparing pixels, only 5 providers differ from origin/main by more than 0.5% RMSE: interac, oxxo, eway, blik and ripple. The rest is rounding noise from the re-export.
🦋 Changeset detectedLatest commit: 21c1ed7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Paymentvariant set in Figma, throughimport/andpnpm run import-payments.lightlogo now has a solid white background. The export frames wrap an instance ofPayment, andcontentsOnlyonly drops the frame's own fill, not the instance's, so the component background ends up in the SVG. Before this branch 162 of 169 light files were transparent and 7 were not; now all 169 are white and consistent. Anyone placing a light logo on a colored background will see the change.paint0_linear_115_1009, which could collide when light and dark render in the same document — exactly what the preview page does.Interac(also resized from 100x70 to 100x60),Oxxo,Eway,BlikandRipple.Preview
Interac,Oxxo,Eway,BlikandRipplein both sections — those are the only ones that should look different. Everything else must look unchanged. In the light section the tiles are now opaque white, so watch for white corners poking out of the rounded borders.Notes / rollout
patchchangesets: the white background, the SVG optimization, and the redrawn logos. All four packages are in a fixed group, so they release together on one version.Oxxo); the rest is rounding noise from the re-export.