Show the Docker Compose instructions without -v - #1102
Open
Amoifr wants to merge 1 commit into
Open
Conversation
The two messages telling the user to run "docker compose up" again went through AbstractConfigurator::write(), which defaults to VERBOSE, so the one action the user has to take was only printed with -v. They are the first callers of the $verbosity argument that write() has carried unused since it was introduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractConfigurator::write()defaults toIOInterface::VERBOSE, so the two messages telling the user to rundocker compose upagain were only printed with-v. That is the one action the user has to take, and it shared a verbosity level with progress lines such asAdding Docker Compose definitions to "compose.yaml", which are fine to keep quiet.Both are now written at
IOInterface::NORMAL. They are the first callers of the$verbosityargumentwrite()has carried unused since it was added.The new test captures the
writeError()calls and checks the verbosity for bothconfigure()andunconfigure(). It fails on2.xwith the level at 4.