Show post-install instructions in composer recipes <package> - #1101
Open
Amoifr wants to merge 1 commit into
Open
Show post-install instructions in composer recipes <package>#1101Amoifr wants to merge 1 commit into
Amoifr wants to merge 1 commit into
Conversation
The instructions a recipe prints at install time scroll away with the rest of the install output and there was no way to read them again. They are now part of what composer recipes <package> shows. The command needs Options to expand the %CONFIG_DIR% style placeholders the same way the installer does, so it is passed along when the command is registered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The instructions a recipe prints at install time scroll away with the rest of the install output, and there was no way to read them again.
composer recipes vendor/packagenow ends with them:The lines go through
Options::expandTargetDir(), so%CONFIG_DIR%and friends read the same as they do during the install. That is the only reason the command now receivesOptions; it is an optional trailing argument and falls back to the raw line when absent, so nothing breaks for anyone constructing the command.No test: there is no
RecipesCommandTesttoday, and this output is only reachable through a fixture that runs a realcomposer install, the wayUpdateRecipesCommandTestdoes. Happy to add one on that pattern if you want it covered.