Repository navigation
Java module system/Jigsaw support for SwiftKitCore(JNI) and SwiftKitFFM - #412
Closed
chengenzhao wants to merge 1 commit into
Closed
chengenzhao wants to merge 1 commit into
chengenzhao wants to merge 1 commit into
Conversation
Collaborator
|
Hmmm ill have to think about this; if there would be no downside to e.g. Android we could consider modularizing right away I guess… |
Collaborator
|
I appreciate the change but I'd like to delay this for now unless we can think of some very specific reason we should do it immediately |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi:
Java 9 introduces Jigsaw/Java module system.
& 25 introduces syntax of import module
so it would be nice to have the Java modularize support.
potential risk:
Not clear the impact of Android port.
thx