Fixed problems when build JavaKitSampleApp on Windows - #400
Merged
Merged
Conversation
Even the URL.path property is deprecated, but there is no other simple way to convert URL to local file path.
Collaborator
|
This is an ok change but we're not currently giving any guarantees this won't regress. If you'b be interested in helping out stand up a windows version of all the github actions that would be helpful towards officially supporting windows. Currently we're still bringing up the tool and library on other platforms and not focused on windows so far. |
ktoso
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are for minimal effect on other parts of the swift-java. With whole picture, there should be better way to make this project cross platforms.
BTW, to successfully build still need to remove dependency of Benchmark in swift-java/Package.swift.