Repository navigation
Cherry-pick swift.org favicon to release/6.4.x - #171
Merged
Merged
Conversation
* updating favicon.ico to use from swift.org, and copy into docc catalogs prior to building/merging * final transform overwrites all the HTML - and the favicon - so we at the moment we need to post-process it back into place * making sure favicon.svg is the Swift logo as well - although visually different from favicon.ico (mask-icon usage expected) * updating gitignore for the favicon.ico replicating * escaping .ico and .svg from license header checks
heckj
force-pushed
the
favicon-6.4.x
branch
from
September 18, 2026 16:12
6c8d0b7 to
13cc9c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release/6.4.x, which builds the publishedlatestdocs.release/6.4.x's published output shows the generic DocC favicon instead of the Swift logo used everywhere else.Test plan
python3 -m unittest test_build_docs— 175 tests pass