Feedback on unsupported types

[olirice]

When a user creates a FDW with an unsupported type, can we reject it with an informative error at creation time rather than at query time?

From User Feedback
https://www.notion.so/supabase/team-postgres-16cf7874025b4b5daf89797af70ce739?p=2693f8cc666a4a3cbd6aee0d2da41223&pm=s

[kiwicopple]

@olirice - let me know if this solves the issue

[olirice]

that PR looks great but this issue is about throwing an error programatically if an unsupported type is referenced from within any wrapper. It would be a framework level change, so I'll leave this open

[jonathansergio]

Hey @olirice! I'd love to take a stab at this.

Since this requires a framework-level change, my initial thought is to hook into the FDW validation phase (likely around validator() or during the ForeignDataWrapper::new initialization). We can iterate over the target Postgres columns being created, check their Oid types against a list of supported types declared by the specific FDW implementation, and gracefully elog!(ERROR, ...) before the table is even created if a mismatch is found.

Does this architectural approach align with what you had in mind for the framework? If so, I can start drafting a PR.

[burmecia]

@jonathansergio, that looks like a good direction, you can go ahead with the PR and we will then start from there, thanks!