Repository navigation
Forward port #1261 and #1262 - #1263
Merged
Merged
Conversation
The backend socket was opened without one, so a write to a backend that stopped acking blocked until the kernel gave up on retransmission. Writes now time out after 30s and close the socket, the same timeout ranch applies to client sockets by default. The DbHandler stops on a closed backend socket in every state, and a ClientHandler writing to it directly gets the error back. (cherry picked from commit f8485c2)
poolboy monitors the ClientHandler that checked a worker out, but the checkin came from the DbHandler. If the ClientHandler died right after releasing, poolboy could handle its DOWN first, hand the worker to a second client, then apply the DbHandler's checkin to that second checkout and hand the worker to a third client while the second was still using it. release/2 is now a call that returns once the DbHandler is idle, and the ClientHandler checks the worker in itself after it. Checkin and DOWN come from the same process, so poolboy sees them in order. (cherry picked from commit c5323aa)
v0idpwn
changed the title
v0idpwn
changed the title
terrywilcox
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #1261 and #1262 from
RELEASE_2_10tomain.release/2returns, so poolboy sees checkin and DOWN in order and can't hand the same worker to two clients.