Conversation
Include stored generated columns in table schema snapshots and let the replication mask decide whether they flow. With `publish_generated_columns = stored` they now reach the destination via copy and CDC; on earlier versions they stay out of the mask, preserving existing behavior. - Add `ColumnSchema.generated`, persisted in `etl.table_columns` - Return `attgenerated` from `etl.describe_table_schema`, and null out `default_expression` so a generation expression never becomes a destination DEFAULT - Exclude generated columns from the pre-PG15 and empty-attnames mask fallbacks, which would widen the mask past the tuple width - Replace the stale "not supported" warning with a mask-aware one - Reject array generated-column additions on ClickHouse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include stored generated columns in table schema snapshots and let the replication mask decide whether they flow. With
publish_generated_columns = storedthey now reach the destination via copy and CDC; on earlier versions they stay out of the mask, preserving existing behavior.ColumnSchema.generated, persisted inetl.table_columnsattgeneratedfrometl.describe_table_schema, and null outdefault_expressionso a generation expression never becomes a destination DEFAULTSolve: #77
What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.