Repository navigation
Conversation
Expose DER and PEM encodings, authority information access, and certificate signature verification through the Node crypto polyfill. Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement
X509Certificate.raw,toString(),infoAccess, andverify()in the Node crypto polyfill. These methods are used by@apple/app-store-server-library@3.1.0when initializing its signed data verifier; the current stubs raiseERR_NOT_IMPLEMENTED.The Rust ops expose the certificate DER and PEM encodings, format Authority Information Access entries, and verify the certificate signature against a supplied
KeyObject. Signature verification covers RSA PKCS#1 v1.5 with SHA-1/256/384/512 and ECDSA with SHA-256/384/512. A certificate fixture checks the encodings, OCSP URI, successful verification, and a tampered signature.Related upstream Deno work: denoland/deno#32270
Validation
cargo check -p ext_nodeand the targeted Rust unit test passed with this patch on the local Edge Runtime branch.RUSTUP_TOOLCHAIN=stable cargo fmt --all --checkandgit diff --checkpassed on this branch.infoAccess,raw,toString(), andverify()output.mainlocally: its pinned Rust 1.98 toolchain is not installed, and the offline dependency cache lacksasync-scoped.