Repository navigation
Conversation
The local stack's random port can start with 1, so the substring check also matched legitimate output such as 127.0.0.1:1663 and failed about 1 run in 9.
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews reported no findings. Reading the changed assertion and surrounding code confirms that the regex still detects all configured port-1 sentinel URLs while avoiding false matches on longer local port numbers. No additional issues or conflicts with pending next-branch work were found.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
CLI benchmark (Lightweight Commands): no changes foundCommit
API calls: unchanged for all 7 commands. Binary size: 134.7 MB, unchanged. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
|
Superseded by #7524, which landed the same fix on develop. |
Summary
The
gen typese2e test gives the CLI an unreachable API URL,http://127.0.0.1:1, and asserts that the output never contains127.0.0.1:1. The local stack's database runs on a random port in 1024–9999, and the CLI prints it (Target: local stack (127.0.0.1:1663)). Any port starting with 1 matched the substring, so about 1 run in 9 failed even though the generated types were correct (example run).The assertion now matches port 1 exactly (
/127\.0\.0\.1:1(?!\d)/). It still catches a request to the sentinel URL and no longer matches any port the stack can pick.