Skip to content

test(cli): match the sentinel API port exactly in the gen types e2e test - #7516

Closed
jgoux wants to merge 1 commit into
developfrom
fix/gen-types-e2e-sentinel-assertion
Closed

jgoux wants to merge 1 commit into
developfrom
fix/gen-types-e2e-sentinel-assertion

Conversation

@jgoux

@jgoux jgoux commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Summary

The gen types e2e test gives the CLI an unreachable API URL, http://127.0.0.1:1, and asserts that the output never contains 127.0.0.1:1. The local stack's database runs on a random port in 1024–9999, and the CLI prints it (Target: local stack (127.0.0.1:1663)). Any port starting with 1 matched the substring, so about 1 run in 9 failed even though the generated types were correct (example run).

The assertion now matches port 1 exactly (/127\.0\.0\.1:1(?!\d)/). It still catches a request to the sentinel URL and no longer matches any port the stack can pick.

The local stack's random port can start with 1, so the substring check also
matched legitimate output such as 127.0.0.1:1663 and failed about 1 run in 9.
@jgoux
jgoux requested a review from a team as a code owner November 5, 2026 15:30
@jgoux
jgoux requested a review from Prashansa-K November 5, 2026 15:30
@jgoux jgoux self-assigned this Nov 5, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews reported no findings. Reading the changed assertion and surrounding code confirms that the regex still detects all configured port-1 sentinel URLs while avoiding false matches on longer local port numbers. No additional issues or conflicts with pending next-branch work were found.

Findings

No issues found.

Stats

Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

CLI benchmark (Lightweight Commands): no changes found

Commit 6f3736d against develop at f530933 · 10 runs each · report only, never blocks merging

Command Workload Before After Change
supabase --version version 367 ms 392 ms no real change (+7%, within normal variation)
supabase --help help 513 ms 470 ms no real change (-8%, within normal variation)
supabase init init 447 ms 474 ms no real change (+6%, within normal variation)
supabase migration new bench migration-new 352 ms 365 ms no real change
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 299 ms 309 ms no real change
supabase projects list projects-list 284 ms 282 ms no real change
supabase functions list --project-ref replayfixtureprojref functions-list 292 ms 300 ms no real change

API calls: unchanged for all 7 commands.

Binary size: 134.7 MB, unchanged.

Details: timing ranges, API calls per command, slowest phases

Timing ranges

Command Workload Before range After range Change Verdict
supabase --version version 312-438 ms 344-497 ms +25 ms (+7%) within noise
supabase --help help 331-607 ms 350-622 ms -43 ms (-8%) within noise
supabase init init 315-652 ms 274-533 ms +27 ms (+6%) within noise
supabase migration new bench migration-new 296-439 ms 260-440 ms +12 ms (+3%) within noise
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 262-375 ms 270-354 ms +10 ms (+3%) within noise
supabase projects list projects-list 255-330 ms 251-336 ms -2 ms (-1%) within noise
supabase functions list --project-ref replayfixtureprojref functions-list 258-350 ms 248-393 ms +8 ms (+3%) within noise

API calls per command

Command Workload Before After Endpoint changes
supabase --version version 0 0
supabase --help help 0 0
supabase init init 0 0
supabase migration new bench migration-new 0 0
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 2 2
supabase projects list projects-list 1 1
supabase functions list --project-ref replayfixtureprojref functions-list 2 2

Slowest phases

No command moved beyond noise, so there are no phase deltas.

Workflow run

Comment /bench to run the lightweight benchmark (this comment) again on the latest commit, or /bench full to also run the integration-heavy benchmark, which posts in its own comment.

@jgoux

jgoux commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #7524, which landed the same fix on develop.

@jgoux jgoux closed this Nov 6, 2026
@jgoux
jgoux deleted the fix/gen-types-e2e-sentinel-assertion branch November 6, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant