Skip to content

fix(cli): keep the windows drive in db start --from-backup (CLI-2930) - #7498

Merged
7ttp merged 1 commit into
developfrom
7ttp/cli-2930-windows-restore-backup-bind-loses-drive-prefix-db-start-may
Nov 4, 2026
Merged

7ttp merged 1 commit into
developfrom
7ttp/cli-2930-windows-restore-backup-bind-loses-drive-prefix-db-start-may

Conversation

@7ttp

@7ttp 7ttp commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

TL;DR

fixes db start --from-backup on windows by passing the host path into the backup bind as is,
like all the other binds do currently...

ref

@7ttp 7ttp self-assigned this Nov 4, 2026
@7ttp
7ttp requested a review from a team as a code owner November 4, 2026 17:36
@7ttp
7ttp requested a review from Coly010 November 4, 2026 17:36
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

CLI benchmark (Lightweight Commands): no changes found

Commit edeab3e against develop at 4d88c8b · 10 runs each · report only, never blocks merging

Command Workload Before After Change
supabase --version version 182 ms 197 ms no real change (+8%, within normal variation)
supabase --help help 200 ms 194 ms no real change
supabase init init 198 ms 197 ms no real change
supabase migration new bench migration-new 205 ms 197 ms no real change
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 217 ms 211 ms no real change
supabase projects list projects-list 211 ms 221 ms no real change
supabase functions list --project-ref replayfixtureprojref functions-list 228 ms 231 ms no real change

API calls: unchanged for all 7 commands.

Binary size: 134.6 MB, unchanged.

Details: timing ranges, API calls per command, slowest phases

Timing ranges

Command Workload Before range After range Change Verdict
supabase --version version 174-248 ms 186-284 ms +15 ms (+8%) within noise
supabase --help help 179-207 ms 178-220 ms -6 ms (-3%) within noise
supabase init init 178-218 ms 177-237 ms -1 ms (-1%) within noise
supabase migration new bench migration-new 182-229 ms 190-230 ms -8 ms (-4%) within noise
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 202-227 ms 204-228 ms -6 ms (-3%) within noise
supabase projects list projects-list 202-231 ms 200-249 ms +10 ms (+5%) within noise
supabase functions list --project-ref replayfixtureprojref functions-list 209-246 ms 215-278 ms +3 ms (+1%) within noise

API calls per command

Command Workload Before After Endpoint changes
supabase --version version 0 0
supabase --help help 0 0
supabase init init 0 0
supabase migration new bench migration-new 0 0
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 2 2
supabase projects list projects-list 1 1
supabase functions list --project-ref replayfixtureprojref functions-list 2 2

Slowest phases

No command moved beyond noise, so there are no phase deltas.

Workflow run

Comment /bench to run the lightweight benchmark (this comment) again on the latest commit, or /bench full to also run the integration-heavy benchmark, which posts in its own comment.

github-actions[bot]

This comment was marked as resolved.

@7ttp
7ttp added this pull request to the merge queue Nov 4, 2026
@kanadgupta kanadgupta changed the title fix(cli): keep the windows drive in db start --from-backup (CLI-2930, CLI-1760) fix(cli): keep the windows drive in db start --from-backup (CLI-2930) Nov 4, 2026
@kanadgupta
kanadgupta removed this pull request from the merge queue due to a manual request Nov 4, 2026
@kanadgupta
kanadgupta added this pull request to the merge queue Nov 4, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 4, 2026
@7ttp
7ttp added this pull request to the merge queue Nov 4, 2026
Merged via the queue into develop with commit a51c49d Nov 4, 2026
93 of 95 checks passed
@7ttp
7ttp deleted the 7ttp/cli-2930-windows-restore-backup-bind-loses-drive-prefix-db-start-may branch November 4, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants