Skip to content

refactor(api): cover the client sources with effect lint (CLI-2841) - #7309

Open
7ttp wants to merge 1 commit into
developfrom
7ttp/cli-2841-src-coverage
Open

7ttp wants to merge 1 commit into
developfrom
7ttp/cli-2841-src-coverage

Conversation

@7ttp

@7ttp 7ttp commented Oct 23, 2026

Copy link
Copy Markdown
Member

TL;DR

brings packages/api/src and its tests under the effect lint

whats introduced?

  • packages/api/src/** joins the allow list, and the generated contracts.ts stays out
  • SupabaseApiConfigError and SupabaseApiInputError move to Data.TaggedError with the same message, name, cause, json and printed output, pinned by a new test, so two apps/cli call sites whose failures include them now yield them directly
  • createApiClient in bun.ts and node.ts chains its promise instead of being async, still disposing the runtime before it rejects
  • the src tests move to effect: FileSystem and Path, schema json codecs, and Effect.runPromise bodies instead of async callbacks

ref

@7ttp 7ttp self-assigned this Oct 23, 2026
@7ttp
7ttp requested a review from a team as a code owner October 23, 2026 16:29
@7ttp
7ttp added this pull request to stack #7311 October 23, 2026 16:30

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews completed and reported zero findings. Inspection of the changed runtime code, error classes, CLI call sites, and test rewrites found no actionable defects or fundamental conflicts with the supplied next-branch context. Tests and type checks were not run because dependencies are absent.

Findings

No issues found.

Stats

Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant