Skip to content

Fix cleanup for custom hooks exercise - #399

Open
ShiroKSH wants to merge 1 commit into
sudheerj:masterfrom
ShiroKSH:fix/coding-exercise-timer-cleanup
Open

Fix cleanup for custom hooks exercise#399
ShiroKSH wants to merge 1 commit into
sudheerj:masterfrom
ShiroKSH:fix/coding-exercise-timer-cleanup

Conversation

@ShiroKSH

@ShiroKSH ShiroKSH commented Aug 1, 2026

Copy link
Copy Markdown

Summary

  • Cancel the simulated request timers when the custom-hooks exercise unmounts.
  • Replace the stale Create React App smoke assertion with the current landing-page heading.
  • Add a regression test covering navigation away before the simulated requests complete.

Root cause

Both simulated requests could outlive their components and attempt state updates after navigation.

Validation

  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant