Feat/unified secp256k1 k256#7305
Open
rob-stacks wants to merge 16 commits into
Open
Conversation
rob-stacks
marked this pull request as ready for review
June 15, 2026 13:51
5 tasks
Contributor
|
I added @benjamin-stacks as a reviewer since he's just been making changes in here. I'll review after he does a pass. 🙏 |
benjamin-stacks
left a comment
benjamin-stacks
left a comment
Contributor
There was a problem hiding this comment.
Just did an initial pass and pointed out a few things that we don't have to implement because they're already provided by those crates.
Will have a deeper look once develop with 30ee31d is merged into this branch.
Comment on lines
+264
to
+265
| /// `recover_to_pubkey`, which already accepts both low-S and high-S signatures | ||
| /// (low-S is enforced separately, e.g. in `verify`, where it matters for consensus). |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch unifies the secp256k1 curve api to use the k256 crate (https://crates.io/crates/k256)
Additional unit tests have been added to ensure the whole api is covered
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/property-testing.md)changelog.d/README.md)rpc/openapi.yamlfor RPC endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo