feat: model experiments wait handler#7800
Open
paul-sffrth wants to merge 8 commits into
Open
Conversation
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
Contributor
|
Thanks for your contribution. Notice.txt is not part of this PR, but I just recognized a point in there. Can you please change the first line to STACKIT Model Experiments SDK for Go |
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
GokceGK
previously approved these changes
Jun 18, 2026
marceljk
reviewed
Jun 18, 2026
| if err != nil { | ||
| log.Fatalf("[Model Experiments] Error when calling `CreateInstance`: %v\n", err) | ||
| } | ||
| log.Printf("[Model Experiments] Triggered creation of Model Experiments Instance with ID: \"%s\".\n", createInstanceResp.Instance.Id) |
Contributor
There was a problem hiding this comment.
nitpick
Suggested change
| log.Printf("[Model Experiments] Triggered creation of Model Experiments Instance with ID: \"%s\".\n", createInstanceResp.Instance.Id) | |
| log.Printf("[Model Experiments] Triggered creation of Model Experiments Instance with ID: %q.\n", createInstanceResp.Instance.Id) |
| if err != nil { | ||
| log.Fatalf("[Model Experiments] Error when waiting for creation: %v\n", err) | ||
| } | ||
| log.Printf("[Model Experiments] Model Experiments Instance \"%s\" has been successfully created.\n", createInstanceResp.Instance.Id) |
Contributor
There was a problem hiding this comment.
Suggested change
| log.Printf("[Model Experiments] Model Experiments Instance \"%s\" has been successfully created.\n", createInstanceResp.Instance.Id) | |
| log.Printf("[Model Experiments] Model Experiments Instance %q has been successfully created.\n", createInstanceResp.Instance.Id) |
| if err != nil { | ||
| log.Fatalf("[Model Experiments] Error when calling `GetInstance`: %v\n", err) | ||
| } | ||
| log.Printf("[Model Experiments] Retrieved Model Experiments Instance with ID: \"%s\" and display name: \"%s\"\n", getInstanceResp.Instance.Id, getInstanceResp.Instance.Name) |
Contributor
There was a problem hiding this comment.
Suggested change
| log.Printf("[Model Experiments] Retrieved Model Experiments Instance with ID: \"%s\" and display name: \"%s\"\n", getInstanceResp.Instance.Id, getInstanceResp.Instance.Name) | |
| log.Printf("[Model Experiments] Retrieved Model Experiments Instance with ID: %q and display name: %q\n", getInstanceResp.Instance.Id, getInstanceResp.Instance.Name) |
| if err != nil { | ||
| log.Fatalf("[Model Experiments] Error when calling `PartialUpdateInstance`: %v\n", err) | ||
| } | ||
| log.Printf("[Model Experiments] Updated Model Experiments Instance with ID: \"%s\" and display name: \"%s\"\n", partialUpdateInstanceResp.Instance.Id, partialUpdateInstanceResp.Instance.Name) |
Contributor
There was a problem hiding this comment.
Suggested change
| log.Printf("[Model Experiments] Updated Model Experiments Instance with ID: \"%s\" and display name: \"%s\"\n", partialUpdateInstanceResp.Instance.Id, partialUpdateInstanceResp.Instance.Name) | |
| log.Printf("[Model Experiments] Updated Model Experiments Instance with ID: %q and display name: %q\n", partialUpdateInstanceResp.Instance.Id, partialUpdateInstanceResp.Instance.Name) |
Contributor
There was a problem hiding this comment.
replace it also in all following prints
Comment on lines
+13
to
+18
| const ( | ||
| INSTANCESTATE_ACTIVE = "active" | ||
| INSTANCESTATE_IMPAIRED = "impaired" | ||
|
|
||
| TOKENSTATE_ACTIVE = "active" | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| const ( | |
| INSTANCESTATE_ACTIVE = "active" | |
| INSTANCESTATE_IMPAIRED = "impaired" | |
| TOKENSTATE_ACTIVE = "active" | |
| ) |
These aren't used at all and should be removed
Comment on lines
+48
to
+49
| }, | ||
| DeleteHttpErrorStatusCodes: []int{http.StatusNotFound}, |
Contributor
There was a problem hiding this comment.
ErrorState is missing
Suggested change
| }, | |
| DeleteHttpErrorStatusCodes: []int{http.StatusNotFound}, | |
| }, | |
| ErrorState: []modelexperiments.InstanceState{modelexperiments.INSTANCESTATE_IMPAIRED}, | |
| DeleteHttpErrorStatusCodes: []int{http.StatusNotFound}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wait handlers for model experiments
Checklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)