Skip to content

Include acl package in host images - #2603

Open
owenjones wants to merge 1 commit into
stackhpc/2025.1from
epoxy-acl
Open

owenjones wants to merge 1 commit into
stackhpc/2025.1from
epoxy-acl

Conversation

@owenjones

Copy link
Copy Markdown
Member

No description provided.

@owenjones
owenjones requested a review from a team as a code owner September 15, 2026 09:26
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: e7270cf9-94aa-4c42-b549-3708fb1a4c23

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 2c235ad3-d7b0-4f00-af26-5b10bb5e1ede

📥 Commits

Reviewing files that changed from the base of the PR and between a8ba4bb and aa264fd.

📒 Files selected for processing (3)
  • etc/kayobe/pulp-host-image-versions.yml
  • etc/kayobe/stackhpc-overcloud-dib.yml
  • releasenotes/notes/host-image-acl-4aad7ee0a83c0375.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
🔇 Additional comments (3)
etc/kayobe/stackhpc-overcloud-dib.yml (1)

86-86: LGTM!

Also applies to: 98-104

releasenotes/notes/host-image-acl-4aad7ee0a83c0375.yaml (1)

1-4: LGTM!

etc/kayobe/pulp-host-image-versions.yml (1)

4-8: LGTM!


📝 Summary

Adds the acl package to overcloud host image builds. Updates host image version tags and records the change in the release notes.

Walkthrough

The change adds acl to host image builds, reorders conditional package entries, updates five overcloud host image version tags, and adds a release note.

Changes

Host image updates

Layer / File(s) Summary
Host image configuration and release note
etc/kayobe/stackhpc-overcloud-dib.yml, releasenotes/notes/host-image-acl-4aad7ee0a83c0375.yaml
The package list adds acl. The distribution-specific entries are reordered. The release note records the package inclusion.
Host image version references
etc/kayobe/pulp-host-image-versions.yml
The Rocky 9, Rocky 9 aarch64, Rocky 10, Rocky 10 aarch64, and Ubuntu Noble image tags are updated to 2025.1-20260914T141734.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to aa264

The change adds the requested host-image package and updates the associated image references; no actionable merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use path_filters to narrow the review scope.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the waiting-review PR is waiting for a review label Sep 15, 2026
The `acl` package is now included in host image builds,
this is required for bootstapping on some systems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants