Skip to content

Don't detect mentions in code blocks #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
judemont wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't detect mentions in code blocks #2726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions api/payIn/lib/item.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@ export async function getItemResult (tx, { id }) {
}

export async function getMentions (tx, { text, userId }) {
const sanitizedText = text.replace(/```[\s\S]*?```/g, ' ')
const mentionPattern = /\B@[\w_]+/gi
const names = text.match(mentionPattern)?.map(m => m.slice(1))
const names = sanitizedText.match(mentionPattern)?.map(m => m.slice(1))
if (names?.length > 0) {
const users = await tx.user.findMany({
where: {
Expand All @@ -48,9 +49,11 @@ export async function getMentions (tx, { text, userId }) {
return []
}


export const getItemMentions = async (tx, { text, userId }) => {
const sanitizedText = text.replace(/```[\s\S]*?```/g, ' ')
const linkPattern = new RegExp(`${process.env.NEXT_PUBLIC_URL}/items/\\d+[a-zA-Z0-9/?=]*`, 'gi')
const refs = text.match(linkPattern)?.map(m => {
const refs = sanitizedText.match(linkPattern)?.map(m => {
try {
const { itemId, commentId } = parseInternalLinks(m)
return Number(commentId || itemId)
Expand Down