feat(api): add task suite management - #234
Conversation
There was a problem hiding this comment.
For the internal handling of requests in the coordinator side (code under service), I haven't reviewed them all. I think we shall discuss and decide on other things first and then we review the service code (because they are likely correct and we only need to check if we have better, more efficient and more human-readable way to write our code).
2ee65b8 to
ba6e4f8
Compare
5b22662 to
533bbd7
Compare
BobAnkh
left a comment
BobAnkh
left a comment
There was a problem hiding this comment.
Please check for all your join select. Mostly I'm fine. Also check what you have returned in the response (including the true response and the error messages). We use typed error messages is because we want to minimize the size of our response, so please also keep that in mind.
91ae109 to
3154f27
Compare
BobAnkh
left a comment
BobAnkh
left a comment
There was a problem hiding this comment.
All is good, only one place needs your further confirmation. Also please test your API and internal service before merging. You can add more tracing::debug to print out more internal state for you to judge if the process is functioning as expected, also for future production debugging and OTEL system.
un-lock-able
changed the title
2 participants
No description provided.