Fix pre commit config generation#57
Merged
Merged
Conversation
For testing the deployment is done on sync-test branch
Member
|
The difference between the C++ cookiecutter and this one here is the following line: This is only present in the Python cookiecutter. That is why the sync CI job on the C++ cookiecutter did create the .pre-commit-config.yaml. However, pre-commit was not run on the baked project since it is not installed. So I think explicitly installing it is a good idea. Although ideally pre-commit should not find anything to complain about in the freshly baked project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on sync-test branch of python-project-template passes, and pre-commit-config.yml is generated.
I also changed "git add *" to "git add -A" in post_gen_project.py, as suggested by @thomasisensee .