fix(api): protect diagnose, series and EV detail on public hosts - #949
Open
frahlg wants to merge 1 commit into
Open
fix(api): protect diagnose, series and EV detail on public hosts#949frahlg wants to merge 1 commit into
frahlg wants to merge 1 commit into
Conversation
Those GET routes leaked more than the live dashboard. A published hostname still serves status, energy, prices, plan, loadpoints and history without a token.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET routes that are not the live dashboard now use the same local-or-token check as config and logs.
Newly protected: driver list and drafts, EV charger detail, series, planner diagnose, fleet-ping, notification rules, device-repository catalog/versions, app-link status.
Still open on purpose: status, energy, prices, plan, loadpoints, history. The dashboard polls loadpoints every 2s; protecting it would pop the house-password modal on every tick.
Test plan
go test ./internal/api(including the new guarded-read cases)make verifyon commit/api/mpc/diagnosewithout token is 401/api/statusand/api/loadpointsstill 200