fix(web): escape dashboard HTML from driver names and plan reasons - #948
Open
frahlg wants to merge 1 commit into
Open
fix(web): escape dashboard HTML from driver names and plan reasons#948frahlg wants to merge 1 commit into
frahlg wants to merge 1 commit into
Conversation
A stored driver name or planner reason could run script in the status bar, the PV curtail picker, and the plan tooltip. Those views had no script CSP.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A stored driver name or planner reason could run script in three dashboard views. The box only sets
frame-ancestorsin CSP, so that script would run as the operator.escHtml.textContent/value), notinnerHTML.escapeHTML.Tests lock the three interpolations.
Why
Anyone who can set a driver name (setup, Settings, YAML) could persist markup. The dashboard reads
/api/statuswithout a login, so every browser that opens the page would run it.Test plan
npm test(365 pass), includingweb/dashboard-xss.test.mjsmake verifyon commit