Skip to content

bug: reset coder on covary and contravary in SCollection #5983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
singhlovepreet9 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bug: reset coder on covary and contravary in SCollection #5983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions scio-core/src/main/scala/com/spotify/scio/values/SCollection.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,13 +275,16 @@ sealed trait SCollection[T] extends PCollectionWrapper[T] {
// =======================================================================

/** lifts this [[SCollection]] to the specified type */
def covary[U >: T]: SCollection[U] = this.asInstanceOf[SCollection[U]]
def covary[U >: T: Coder]: SCollection[U] =
this.asInstanceOf[SCollection[U]].setCoder(CoderMaterializer.beam(context, Coder[U]))

/** lifts this [[SCollection]] to the specified type */
def covary_[U](implicit @unused ev: T <:< U): SCollection[U] = this.asInstanceOf[SCollection[U]]
def covary_[U: Coder](implicit @unused ev: T <:< U): SCollection[U] =
this.asInstanceOf[SCollection[U]].setCoder(CoderMaterializer.beam(context, Coder[U]))

/** lifts this [[SCollection]] to the specified type */
def contravary[U <: T]: SCollection[U] = this.asInstanceOf[SCollection[U]]
def contravary[U <: T: Coder]: SCollection[U] =
this.asInstanceOf[SCollection[U]].setCoder(CoderMaterializer.beam(context, Coder[U]))

/**
* Convert this SCollection to an [[SCollectionWithFanout]] that uses an intermediate node to
Expand Down