[ports] Add behaviour and name to port conversion error messages - #517
Merged
Merged
Conversation
sea-bass
reviewed
Sep 17, 2026
sea-bass
left a comment
sea-bass
left a comment
Member
There was a problem hiding this comment.
Thanks! I would almost do the message the opposite:
Failed to do X In behavior name "foo" (type MyGreatBehaviour)
eholum
force-pushed
the
port-type-remapping
branch
from
September 17, 2026 18:34
9b6a8ef to
4c55d9e
Compare
eholum
force-pushed
the
port-type-remapping
branch
from
September 17, 2026 18:37
4c55d9e to
0f1a7e3
Compare
Member
|
Looks like something done broke on main. Gonna merge this and fix the rest after |
sea-bass
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As our behavior trees have gotten larger we've sometimes run into port value errors that can be difficult to localize, as they get buried in trees. Specifically:
This change just updates those error messages to include the behavior type and name to make finding invalid port entries easier. Both things were already available in the function, so no other changes required.
After: