Skip to content

fix: address CodeQL archive and allocation findings - #20

Merged
aledbf merged 2 commits into
mainfrom
fix/archive-extraction-codeql
Aug 25, 2026
Merged

fix: address CodeQL archive and allocation findings#20
aledbf merged 2 commits into
mainfrom
fix/archive-extraction-codeql

Conversation

@aledbf

@aledbf aledbf commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • avoid the potentially overflowing capacity sum when merging cache-from values
  • validate tar entry names as local platform paths before extraction
  • confine Feature archive filesystem operations with os.Root, including symlink traversal protection
  • strengthen cache merge aliasing coverage and add a symlink-escape regression test

Validation

  • PASS: go test ./internal/cli -run Test(CacheFromForDockerfileBuild|ExtractTarGz) -count=1
  • PASS: task lint
  • PASS: internal/cli under task test:race
  • NOTE: the complete task test:race run reached an unrelated existing failure in internal/oci/TestResolveBuildAuthFromOCIEnvAndGitHubToken because the local Docker credential store overrides its fixture token
  • NOTE: an unfiltered internal/cli run reached unrelated parity failures caused by the local TypeScript oracle, including a missing pty.node native module

@aledbf
aledbf merged commit 891547d into main Aug 25, 2026
23 of 25 checks passed
@aledbf
aledbf deleted the fix/archive-extraction-codeql branch August 25, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant