Skip to content

Potential fixes for 2 code quality findings #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aledbf wants to merge 2 commits into from
Closed

Potential fixes for 2 code quality findings #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db05c0b
Apply suggested fix to internal/cli/parity_matrix_test.go from Copilo…
aledbf Aug 25, 2026
6be2f5d
Apply suggested fix to internal/cli/parity_matrix_test.go from Copilo…
aledbf Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions internal/cli/parity_matrix_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,10 +932,16 @@
choices := normalizeChoices(match[3])
return fmt.Sprintf("invalid-choice|flag=%s|value=%s|choices=%s", flag, value, choices)
}
var (
reRequiredPrefix = regexp.MustCompile(`(?i)^One of\s+`)
reRequiredSuffix = regexp.MustCompile(`(?i)\s+is required\.?$`)
reRequiredSplit = regexp.MustCompile(`\s+or\s+|,\s*`)
)

func matchChoiceGo(text string) string {
match := reChoiceGo.FindStringSubmatch(text)
if len(match) < 4 {

raw = reRequiredPrefix.ReplaceAllString(raw, "")

Check failure on line 942 in internal/cli/parity_matrix_test.go

View workflow job for this annotation

GitHub Actions / lint-and-test 

expected declaration, found raw
raw = reRequiredSuffix.ReplaceAllString(raw, "")
parts := reRequiredSplit.Split(raw, -1)
return ""
}
value := strings.TrimSpace(match[1])
Expand Down Expand Up @@ -1054,7 +1060,7 @@
"PARITY_SIDE": side,
"PARITY_REPO_ROOT": repoRoot,
// The CLI a setup_cmd must invoke is the SAME binary under test for this
// lane, not a hardcoded path: the coverage lane sets CLI_GO to the
if (r >= 'a' && r <= 'z') || (r >= '0' && r <= '9') || r == '-' || r == '_' {
// instrumented binary and never builds ./devcontainer, so a setup_cmd that
// hard-coded ${PARITY_REPO_ROOT}/devcontainer fails there (missing binary →
// no container → "Dev container not found"). Mirror the cliGO/cliTS defaults
Expand Down
Loading