test: assert the existing language fixtures - #81
Open
lvolland wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
examples/languages/test.*is already the test suite — every fix since #53 adds a line to it. this doesn't add a corpus, it records what the tokenizer produces for yours.paste this:
today nothing happens. after: 3 red —
test.js,test.md,test.ts. md and ts pull js in with a spread, so #70 broke them too. not visible by eye.reverting each fix in turn, 6/6 go red on the right language: #53 py, #54 json, #56 md, #58 py, #66 ini, #70 js+md+ts.
no dependency,
node --testis built in. nothing lands insrc/ordist/; the tarball stays at 263 files, +43 bytes for the"test"line. 0.2s.notes
UPDATE=1refreshes snapshots, but the "tokens must join back into the source" assert runs first — a refresh can't bless dropped code. with a token-dropping mutation it leaves 35/36 red and writes nothing.UPDATE=1diffs will show improvements that look like regressions..gitattributespins fixtures and snapshots to-text— without it they check out CRLF on windows and the suite fails 36/36.test.ymlruns on prs and on push to main, since all six fixes were direct pushes. informational only:release.ymldoesn't depend on it.detect.js,terminal.jsor the html output.tests/dir, no hard feelings 🙂