fix: delimiters in rs, go, java and lua - #77
Open
lvolland wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
four multi-char delimiters aren't recognized, so each one swallows the rest of the line — or the file.
--[[ block ]]today: rust
'areads as an unterminated char literal and eats the signature (str "'a>(msg: &'"), go backticks aren't a string at all, lua block comments only close on--]], and java text blocks split into""+".expected:
type,str,cmnt,str.one rule added per language, two chars dropped from the lua one. the java rule is py.js line 23 with a literal instead of the backreference, since java has only one delimiter:
/"""(\\[^]|(?!""")[^])*(""")?/g. closing delimiters stay optional so half-typed code keeps its color. +180 bytes in src,dist/untouched, fixture lines added for all four.notes
expand: 'str'on purpose. with str first,&'a strgoes back tostr "'a>(msg: &'". the(?!')is what keeps'x'a char literal.'A) still fall through, same as before — didn't want to widen the rule for it."""or backtick now colors to end of file. that's the price of the optional closer.]], not--]]. the--[[ ... --]]toggle idiom still works.