Use ruff-format instead of yapf - #2546
Open
ThrudPrimrose wants to merge 8 commits into
Open
Conversation
Replace the yapf pre-commit hook with `ruff-format` from the ruff-pre-commit repo already pinned in the config, so formatting and linting run out of a single tool. `ruff format` is substantially faster than yapf on the whole tree. Configuration moves from `.style.yapf` into `ruff.toml`: `line-length = 120` keeps the previous `column_limit`, and `quote-style = "preserve"` avoids a mass single-to-double quote rewrite. The linting dependency group swaps yapf for a matching ruff pin, and uv.lock is regenerated accordingly.
Mechanical reformat produced by `pre-commit run --all-files` with the `ruff-format` hook. No behavioral changes. Two differences from yapf show up throughout: docstring bodies lose the padding spaces inside the triple quotes, and argument lists that exceed the line length are split one-per-line instead of packed to the column limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the yapf pre-commit hook with
ruff-formatfrom the ruff-pre-commit repo already pinned in the config, so formatting and linting run out of one tool;line-length = 120andquote-style = "preserve"inruff.tomlcarry over the old.style.yapfsettings. The second commit is the resulting mechanical tree-wide reformat, listed in.git-blame-ignore-revs.The problem with switching the ruff is following:
""" Text. """ becomes """Text.""".And this:
These 2 result in this massive +37k, -27k change.