[New GPU Codegen Prep] An unused array must not leak its shape symbol into the signature - #2529
Draft
ThrudPrimrose wants to merge 3 commits into
Draft
[New GPU Codegen Prep] An unused array must not leak its shape symbol into the signature#2529ThrudPrimrose wants to merge 3 commits into
ThrudPrimrose wants to merge 3 commits into
Conversation
Every declared array's stride/shape/offset symbols were expanded into the SDFG's free symbols, so declaring an unused transient changed `arglist()` and `init_signature()` (issue #2382). Only the arrays `read_and_write_sets` reports as used are expanded now -- a set that already includes the arrays referenced solely by a code-block guard, which is the case that motivated the original code.
ThrudPrimrose
marked this pull request as ready for review
August 26, 2026 11:28
ThrudPrimrose
marked this pull request as draft
August 26, 2026 16:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands the extent symbols of only the arrays
read_and_write_setsreports as used, so declaring an unused transient no longer changesarglist()orinit_signature()(issue #2382). Split out of the new GPU codegen PR (#2259) as a prerequisite.