Repository navigation
Conversation
A depth-zero restart discards every drain frame. Clear its saved return PC as well so a later interpreter fallback cannot stop at an obsolete boundary. Extend the existing synthetic fixture for nested reset, direct reset, and task resume; all three fail on upstream master without the clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A guest stack reset or task resume longjmps back to the driver at host depth zero. That discards every drain frame, but the old innermost
drain_ret_pcsurvives. If a later interpreter fallback reaches that stale address, it can stop immediately and leave the run outside its intended continuation.Clear the abandoned drain return point when handling the driver restart. This is the minimal generic part of the validated fork fix
fb89f51e; no diagnostic fields, environment switches, or policy changes are added upstream.The existing synthetic lifted-thread launch fixture now leaves a nonzero drain return point before nested reset, direct reset, and task resume. On current upstream
de4f0903, all three new assertions fail (164 passed, 3 failed). With the clear, the full fixture passes 167 checks, including the existing host-depth and obsolete-caller-continuation checks. The existing macOS and Linux workflows already compile and run this fixture. Local validation used nice 15, manufactured guest memory/code only, and no GUI/GPU work.