Repository navigation
perf: fix performance when applying large numbers of type unions - #2329
Open
HoneyryderChuck wants to merge 1 commit into
Open
HoneyryderChuck wants to merge 1 commit into
HoneyryderChuck wants to merge 1 commit into
Conversation
the handling of union types, particularly bad when used with records, creates transitive interfaces with the union of all methods from each option; a lot of these methods are common across records, but they wouldn't be deduped, thereby being union'ed several times while joined, to the point where a 12 member union could take +10m to load. This fixes the behaviour by: 1: removing method overload dead pairs for `[]` calls for combinations which cannot be called. 2: removing duplicates from the same overload, which weren't identified due to pair ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the handling of union types, particularly bad when used with records, creates transitive interfaces with the union of all methods from each option; a lot of these methods are common across records, but they wouldn't be deduped, thereby being union'ed several times while joined, to the point where a 12 member union could take +10m to load.
This fixes the behaviour by:
1: removing method overload dead pairs for
[]calls for combinationswhich cannot be called.
2: removing duplicates from the same overload, which weren't identified
due to pair ordering.
To reproduce this in the master branch, you can use the following script: