Repository navigation
Fix ground station profile save returning 500 - #381
Merged
Merged
Conversation
ObservationProfile.from_row called row.get() on a sqlite3.Row, which has no .get(), so reading a saved profile back raised and the dashboard saw an HTML 500 it reported as invalid JSON. Index the column directly and add a regression test covering save, read back, list and delete. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
meshcore 2.3.16 (released 2026-10-14) declares requires-python>=3.10 but uses f-string syntax only valid on 3.12+, so importing it raises SyntaxError on 3.11 (CI and the python:3.11-slim Docker image). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ObservationProfile.from_rowcalledrow.get("tasks_json")on asqlite3.Row, which has no.get(). Saving a profile reads it back, so every save raised and returned an HTML 500 that the dashboard reported as invalid JSON. Index the column directly.tests/test_ground_station_profiles.pycovering save, read back, list and delete (fails before the fix, passes after).meshcore2.3.16 (released 2026-10-14). It declaresrequires-python>=3.10but uses 3.12-only f-string syntax, so it raisesSyntaxErroron import under 3.11 — this broke CI (conftest import) and would break thepython:3.11-slimDocker image.Test plan
pytest tests/test_ground_station_profiles.py🤖 Generated with Claude Code