ReBenchDB.send_results() is expected to return only a bool#298
Merged
Conversation
smarr
force-pushed
the
fix-result-of-sending-to-rebenchdb
branch
from
2758580 to
67cc33b
Compare
|
coverage: 85.04% (+0.05%) from 84.992% — fix-result-of-sending-to-rebenchdb into master |
Signed-off-by: Stefan Marr <git@stefan-marr.de>
After the time out is at 5min, cap it here. Wait 10 times but do a exponential backoff only until we reach a 5min wait time. Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
force-pushed
the
fix-result-of-sending-to-rebenchdb
branch
from
ec202dd to
afb43ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were returning a tuple of bool and string, and checked for true, which would always be true instead of actually looking at the success flag.
This now returns only the flag, which is the right bool to check.
In addition, we change the backoff behavior when sending data fails.
We cap the backoff at 5min, and will try up to 10 times.