Navigation safe area subcompose refactor - #494
Draft
dfabulich wants to merge 2 commits into
Draft
Conversation
This eliminates the need to use `onGloballyPositioned` to measure the app bar, eliminating layout shift.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WindowInsetsinstead of a_safeAreaenvironment value #493This is currently a draft PR partly because I'm not yet sure there are enough tests, and also because I'm not sure this is the right direction.
This PR uses
SubcomposeLayoutto layout theTopAppBarand the body content of theNavigationStack, mirroring the implementation of ComposeScaffold(see their implementation.)This eliminates the need to use
onGloballyPositionedto measure the app bar, eliminating layout shift.Skip Pull Request Checklist:
swift test(Not required)
Cursor generated the core of this PR. I manually tested it with the Showcase app in the SafeAreaPlayground, but I'm not confident I've done enough manual testing; I don't want to invest a lot of energy into it unless we agree that this is something like the right approach.