Skip to content

Create the CLLocationManager instance on the main thread - #40

Open
maccheck wants to merge 1 commit into
skiptools:mainfrom
maccheck:main
Open

Create the CLLocationManager instance on the main thread#40
maccheck wants to merge 1 commit into
skiptools:mainfrom
maccheck:main

Conversation

@maccheck

Copy link
Copy Markdown

Delegate methods need to have a thread with a RunLoop. This pull request should take care of that.

Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.

Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Delegate methods need to have a thread with an RunLoop.
@cla-bot

cla-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to the Skip community. We require contributors to sign our contributor license agreement (CLA), and we don't seem to have the user(s) @maccheck on file. In order for us to review and merge your code, for each noted user please add your GitHub username to Skip's .clabot file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant