Repository navigation
Real reviews after the first lesson, designs A, A, A, off by default (T-0898) - #97
Merged
Merged
Conversation
…OFF until REVIEWS_FLOW=on (T-0898) Invitation mail with five star links after the first lesson, a one-card review form, a summary card and the tutor's one answer on the profile. Migration 027 (written, not applied) holds the rules in the database. Old reviews and the old form are untouched while off. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Helme-Agent: toiuuram project agent Helme-Account: claude-wp Helme-Model: claude-sonnet-5-5 Helme-Session: 83c30d74-7a50-4367-9b08-1d05764b7358
Bugbot is paused — your team has an unpaid invoiceBugbot is paused because your team has an unpaid invoice. Pay it from the billing page in the Cursor dashboard and Bugbot resumes automatically. (requestId: 237d7ddf-9611-4e6d-86ea-40e44e6bdcb6) |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
T-0898: real reviews after a student's first lesson, built from the designs the owner chose (1A the email with five star links, 2A one card with stars, tags and a few words, 3A a summary card then the reviews) and the owner's rules (W-2747). OFF by default: with
REVIEWS_FLOWnot exactlyon, no invitation goes out and nothing new shows; the old form, the old route and the old reviews list work as before. The full description, the rules and the steps to turn it on are indocs/reviews-flow.md.027_reviews_flow.sql(written and tried on a throwaway Postgres, not run on the real database): new columns, one review per student per tutor, the tutor's old "all rights" policy on reviews becomes read-only, browser keys lose insert/update/delete on reviews, and a trigger keeps the rules even for the server's key (edit for 7 days, answer once, a review keeps its student, tutor, lesson and date). New tablereview_invites(row level security on, no policy)./portal/<link>/review/<lesson>; on a profile a summary card and the list (name as "Maria K.", lessons taken, tags, the tutor's one answer; the signed-in tutor sees the answer box).Checked
tests/reviews-flow.test.ts(rules, routes, invitation, pages, switch off and on; a mutation check without the ownership checks makes four fail),tests/reviews-flow-limits.test.ts,tests/reviews-flow-migration.test.ts(PGlite: idempotent, old reviews untouched, shape, 7 days, answer once, browser keys never write, a tutor reads only their own, nobody with a browser key reads the invitations), three profile tests. Typecheck, line-refs, build, lint of the new files: pass.Limits
REVIEWS_FLOW=onare the owner's steps; nothing was run on the real database or on Vercel.Updates: not applicable while the switch is off (nobody sees a difference); an entry with a picture is written when it is turned on.
🤖 Generated with Claude Code