Repository navigation
Second visual review of the tutor app: names for 40 form fields, readable placeholders, Calendar opens at your lessons (T-0842) - #87
Merged
Conversation
…pale greys, sizes under 12px, tinted chips, solid buttons, bell badge in dark, names for icon-only controls, Upgrade Pro card, chart label (T-0842) A browser audit of 28 tutor pages at 1920, 1440 and 390 px in both themes found pale grey text (1.5 to 4.4 to 1), text of 7.9 to 11px, a bell badge at 2.8 to 1 in dark, white text on 2.5 to 1 buttons and icon-only links with no name on the pages not rebuilt yet. One floor in the shell stylesheet fixes the classes those pages use; tests/dashboard-legibility.test.ts keeps it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Helme-Agent: toiuuram lane qa Helme-Account: claude-wp Helme-Model: claude-sonnet-5-5 Helme-Session: 947b978f-f030-47d2-b818-b8376407068b
…ilability-grid (PR #84) Both PRs append to the end of src/styles/dashboard-shell.css; both blocks are kept. This merge only exists so the second visual review (T-0842) is measured and built on the pages of both. When #83 and #84 are merged into master the merge adds nothing. Helme-Agent: toiuuram project agent Helme-Account: claude-wp Helme-Model: claude-sonnet-5-5 Helme-Session: 2dfffb30-6222-4eda-a6be-dc03d6fb9dad
…able placeholders and muted text, Calendar week opens at the first lesson, five contrast fixes in Settings and the lesson form (T-0842) Browser audit of 33 pages x 1920/1440/390 px x light/dark (+ 19 pages as a Free tutor, + account menu, bell and command bar open), fake Supabase, production build. Before: placeholders 1.47 to 1 (placeholder:text-gray-300), 40 inputs/textareas/selects with only a placeholder as a name, select placeholder 3.63 to 1 in dark, white on the Google button 3.56 to 1, indigo-200 text on the Plan card 4.21 to 1, bell close button with no name, Calendar week grid opening at 6 AM. After: 0 sideways scroll, 0 text under 12px, 0 text or placeholder under 4.5 to 1, 0 unnamed controls, in every measured combination. - dashboard-shell.css: .dash ::placeholder and --muted-foreground read --d-ink-3; the week hours scroll inside the grid with the day names above (same scrollbar gutter on both) - calendar: openingMinute() (src/lib/calendar.ts) and an effect that scrolls the grid to it - labels: htmlFor/id or aria-label on every field of the lesson, student, Team, AI tools, Messages, Settings sections and the dashboard search; aria-label on the bell close button - Settings: Google button #1a73e8, Plan card text indigo-100 - tests: unnamedControls() scan (with a mutation on the real lesson form), placeholder and muted-ink rules with mutations, tests/calendar-opening.test.ts - update entry 1.16.2 with a picture Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Helme-Agent: toiuuram project agent Helme-Account: claude-wp Helme-Model: claude-sonnet-5-5 Helme-Session: 2dfffb30-6222-4eda-a6be-dc03d6fb9dad
Bugbot is paused — your team has an unpaid invoiceBugbot is paused because your team has an unpaid invoice. Pay it from the billing page in the Cursor dashboard and Bugbot resumes automatically. (requestId: 3feab1cf-81e7-403d-82c4-e5f19085f9c5) |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…usiness-list fixes, tutor-app legibility and public pages review blocks of the feature map Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Helme-Agent: toiuuram lane merge-fix Helme-Account: claude-wp Helme-Model: claude-sonnet-5-5 Helme-Session: f9cf9692-2dbc-4b4c-8e37-e26934049d00
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Helme-Agent: toiuuram lane merge-fix Helme-Account: claude-wp Helme-Model: claude-sonnet-5-5 Helme-Session: f9cf9692-2dbc-4b4c-8e37-e26934049d00
Bugbot is paused — your team has an unpaid invoiceBugbot is paused because your team has an unpaid invoice. Pay it from the billing page in the Cursor dashboard and Bugbot resumes automatically. (requestId: 79a26eef-60bf-4533-a3dd-06be86c33fa1) |
…ility and the public pages review blocks of the feature map Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Helme-Agent: toiuuram lane merge-fix Helme-Account: claude-wp Helme-Model: claude-sonnet-5-5 Helme-Session: f9cf9692-2dbc-4b4c-8e37-e26934049d00
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Helme-Agent: toiuuram lane merge-fix Helme-Account: claude-wp Helme-Model: claude-sonnet-5-5 Helme-Session: f9cf9692-2dbc-4b4c-8e37-e26934049d00
…p legibility block with the brand and answers block Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Helme-Agent: toiuuram lane merge-fix Helme-Account: claude-wp Helme-Model: claude-sonnet-5-5 Helme-Session: f9cf9692-2dbc-4b4c-8e37-e26934049d00
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Helme-Agent: toiuuram lane merge-fix Helme-Account: claude-wp Helme-Model: claude-sonnet-5-5 Helme-Session: f9cf9692-2dbc-4b4c-8e37-e26934049d00
…p legibility block with the brand and answers, public pages review and numbers blocks Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Helme-Agent: toiuuram lane merge-fix Helme-Account: claude-wp Helme-Model: claude-sonnet-5-5 Helme-Session: f9cf9692-2dbc-4b4c-8e37-e26934049d00
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Helme-Agent: toiuuram lane merge-fix Helme-Account: claude-wp Helme-Model: claude-sonnet-5-5 Helme-Session: f9cf9692-2dbc-4b4c-8e37-e26934049d00
Bugbot is paused — your team has an unpaid invoiceBugbot is paused because your team has an unpaid invoice. Pay it from the billing page in the Cursor dashboard and Bugbot resumes automatically. (requestId: bdb508a9-b51f-45a8-a905-9e4c4ef29ed9) |
…ty block and the availability grid and Settings section blocks of dashboard-shell.css, count 98 test files Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Helme-Agent: toiuuram lane merge-fix Helme-Account: claude-wp Helme-Model: claude-sonnet-5-5 Helme-Session: e957d845-3559-49f0-b889-084e75cb11b1
…udes master after #84) into PR #87 branch: one legibility block at the end of dashboard-shell.css beside the availability grid and Settings blocks, feature-map lines of #87 kept Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Helme-Agent: toiuuram lane merge-fix Helme-Account: claude-wp Helme-Model: claude-sonnet-5-5 Helme-Session: e957d845-3559-49f0-b889-084e75cb11b1
Bugbot is paused — your team has an unpaid invoiceBugbot is paused because your team has an unpaid invoice. Pay it from the billing page in the Cursor dashboard and Bugbot resumes automatically. (requestId: e5c3a80b-1fc4-4801-99ce-fa630a288a20) |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge order: #83 and #84 first (this branch contains both, merged; after they are in master this pull request shows only its own commit
01f6d2c).Browser audit of 33 pages x 1920/1440/390 px x light/dark (fake Supabase, production build), plus 19 pages as a Free tutor and the account menu, bell and command bar open: 330 measured combinations.
Before: placeholders 1.47 to 1, 40 form fields whose only name was a placeholder, select placeholder 3.63 to 1 in dark, white on the Google button 3.56 to 1, Plan card text 4.21 to 1, bell close button with no name, Calendar week opening at 6 AM.
After: 0 sideways scroll, 0 text under 12px, 0 text or placeholder under 4.5 to 1, 0 unnamed controls.
Tests:
tests/dashboard-legibility.test.ts(unnamed-control scan with a mutation on the real lesson form, placeholder and muted-ink rules with mutations) andtests/calendar-opening.test.ts.npm test1460 tests, 0 failed;tsc --noEmitclean.Tom tat (VI): ra soat hinh anh lan hai, dat ten cho 40 o nhap, chu goi y de doc, lich tuan mo dung cho co buoi hoc. Bao cao day du trong Brain (inbox). Gop sau #83 va #84.
🤖 Generated with Claude Code