do not plot missleding plot - #1240
Conversation
Screen.Recording.2026-08-05.132846.mp4 |
| self.mainLayout.setContentsMargins(0, 0, 0, 0) | ||
| self.mainLayout.setSpacing(0) | ||
| self.sourceList = [] | ||
| self.compatibility = True |
There was a problem hiding this comment.
compatibility with what?
There was a problem hiding this comment.
Of selected scans to be plotted or motor names in scans (depending from which perspective to look on it).
rename into coincide_motors_names? or plots_compatibility?
| traceback.format_exc()) | ||
| msg.exec() | ||
| continue | ||
| # see QNexusWidget |
| elif len(sel_list) > 1: | ||
| self._addSelectionSlot([sel_list[0]], event="replaceSelection") | ||
| self._addSelectionSlot(sel_list[1:], event="addSelection") | ||
| if self.compatibility == True: |
There was a problem hiding this comment.
| if self.compatibility == True: | |
| if self.compatibility: |
compatibility does not need to be public and needs a better name.
Judging from it usage _canBeAdded?
There was a problem hiding this comment.
I'm worried about self.compatibility (apart from the name and its public nature).
It seems that the idea is
- the first
_addSelectionSlotcall resetsself.compatibility=True/False - if
_addSelectionSlotwe do the second call - the first
_addSelectionSlotcall resetsself.compatibility=True/False
What happens with self.compatibility=True/False from the second call? Could it be different than the first call?
To me it seems like we don't need self.compatibility and instead _addSelectionSlot should return something.
|
I did it through |
|
The remain misleading thing is that selection in the HDF5 tree remain, but it is probably OK... |
|
selection misleading: Screen.Recording.2026-08-06.165731.mp4 |
|
Suggestion/idea for another PR would be to do the following: |
2 participants
Fix bug reported in #1227
It respects the feature of selecting more than 4 scans at a time.
To be clear the bug reported in #1227 was happening ONLY in "AUTO" tab for counters/motors