SF-1523 Prevent project deleted dialog from being shown repeatedly

src/SIL.XForge.Scripture/ClientApp/src/app/app.component.spec.ts

@@ -123,7 +123,7 @@
       { provide: ErrorReportingService, useMock: mockedErrorReportingService },
       { provide: BreakpointObserver, useClass: TestBreakpointObserver },
       { provide: DialogService, useMock: mockedDialogService },
       provideNoopAnimations()
     ]
   }));
 
@@ -372,6 +372,20 @@
     expect(env.location.path()).toEqual('/projects');
   }));
 
+  it('shows the removed from project dialog once when the project keeps changing', fakeAsync(() => {
+    const env = new TestEnvironment();
+    env.navigate(['/projects', 'project01']);
+    env.init();
+
+    expect(env.selectedProjectId).toEqual('project01');
+    // The sync that removes the user goes on to change the project before the app has navigated away
+    env.removeUserFromProject('project01', { thenChangeProjectTimes: 2 });
+
+    verify(mockedDialogService.message(anything())).once();
+    verify(mockedSFProjectService.localDelete('project01')).once();
+    expect(env.location.path()).toEqual('/projects');
+  }));
+
   it('response to remote project change for serval admin', fakeAsync(() => {
     const env = new TestEnvironment();
     env.setCurrentUser('user05');
@@ -1009,9 +1023,12 @@
     this.wait();
   }
 
-  removeUserFromProject(projectId: string): void {
+  removeUserFromProject(projectId: string, { thenChangeProjectTimes = 0 } = {}): void {
     const projectDoc = this.realtimeService.get<SFProjectProfileDoc>(SFProjectProfileDoc.COLLECTION, projectId);
     projectDoc.submitJson0Op(op => op.unset<string>(p => p.userRoles['user01']), false);
+    for (let i = 0; i < thenChangeProjectTimes; i++) {
+      projectDoc.submitJson0Op(op => op.inc(p => p.sync.queuedCount, 1), false);
+    }
     this.wait();
   }
 

src/SIL.XForge.Scripture/ClientApp/src/app/app.component.ts

@@ -377,9 +377,13 @@ export class AppComponent extends DataLoadingComponent implements OnInit, OnDest
             }
             // See if the user was removed from the project
             if (!(this.currentUserDoc.id in this._selectedProjectDoc.data.userRoles)) {
-              // The user has been removed from the project
+              // The user has been removed from the project, so unsubscribe to prevent multiple notices
+              this.selectedProjectChangedSub?.unsubscribe();
+              this.selectedProjectDeleteSub?.unsubscribe();
               void this.showProjectDeletedDialog();
               void this.projectService.localDelete(this._selectedProjectDoc.id);
+              // showProjectDeletedDialog redirects, so return early to avoid redirect checkAppAccess would do
+              return;
             }
 
             checkAppAccess(