Skip to content

SF-3442 Fix join page having loading title - #4250

Open
Nateowami wants to merge 1 commit into
masterfrom
fix/SF-3442-join-page-has-loading-title
Open

Nateowami wants to merge 1 commit into
masterfrom
fix/SF-3442-join-page-has-loading-title

Conversation

@Nateowami

@Nateowami Nateowami commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@Nateowami Nateowami added the will require testing PR should not be merged until testers confirm testing is complete label Nov 6, 2026
@codecov

codecov Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.30%. Comparing base (c429a36) to head (7b09c14).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4250   +/-   ##
=======================================
  Coverage   81.30%   81.30%           
=======================================
  Files         671      671           
  Lines       43020    43020           
  Branches     7138     7138           
=======================================
  Hits        34976    34976           
  Misses       6877     6877           
  Partials     1167     1167           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami added ai-review-reviewer-sign-off PR reviewer has looked at AI review of change and determined no findings warrant further changes ai-review-author-sign-off PR author has looked at AI review of change and determined no findings warrant further changes and removed ai-review-reviewer-sign-off PR reviewer has looked at AI review of change and determined no findings warrant further changes labels Nov 6, 2026
@Nateowami
Nateowami marked this pull request as ready for review November 6, 2026 22:32
@pmachapman
pmachapman self-requested a review November 8, 2026 22:23
@pmachapman pmachapman self-assigned this Nov 8, 2026

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thank you for fixing this - it looks like this was a bug I introduced in #3203.

@pmachapman reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Nov 8, 2026

This branch was previously deployed

1 inactive deployment
screenshot_diff — 7b09c142 Deployed Nov 6, 2026 by Nateowami via Compare Screenshots #1299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-author-sign-off PR author has looked at AI review of change and determined no findings warrant further changes ready to test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants